(PA-6543) Bump wixtoolset to 3.14.1 in puppet-agent main #2557
Conversation
We use '--ignore-dependencies' flag to install wixtoolset since it depends on DotNet3.5 which breaks when installing: wixtoolset/issues#5523. Seems we don't need it for our use case, we can leave it out.
|
The build succeeds and all impacted windows platforms pass the ad-hoc integrations tests: |
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| #FIXME we need Fips Compliant Wix, currently not in choco repositories | |||
| #plat.provision_with "C:/ProgramData/chocolatey/bin/choco.exe install -y Wix310 -version 3.10.2 -debug -x86 --no-progress" | |||
| plat.provision_with "curl -L -o /tmp/wix314-binaries.zip https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/windows/wix3/wix3.14.0.6526-binaries.zip && \"C:/Program Files/7-Zip/7z.exe\" x -y -o\"C:/Program Files (x86)/WiX Toolset v3.14/bin\" C:/cygwin64/tmp/wix314-binaries.zip && rm /tmp/wix314-binaries.zip && SETX WIX \"C:\\Program Files (x86)\\WiX Toolset v3.14\" /M" | |||
| plat.provision_with "curl -L -o /tmp/wix314-binaries.zip https://artifactory.delivery.puppetlabs.net/artifactory/generic__buildsources/buildsources/wix314-binaries.zip && \"C:/Program Files/7-Zip/7z.exe\" x -y -o\"C:/Program Files (x86)/WiX Toolset v3.14/bin\" C:/cygwin64/tmp/wix314-binaries.zip && rm /tmp/wix314-binaries.zip && SETX WIX \"C:\\Program Files (x86)\\WiX Toolset v3.14\" /M" | |||
There was a problem hiding this comment.
Noticed this after merging, but it's a good idea to pass --fail and --retry.
The fail option is important because if artifactory's response with non-20x, then curl will save the HTML response as the output file!!, e.g. "...
Internal Server Error...", return exit code 0 (success). Then we try to unzip the html file, which fails in ways that are hard to troubleshoot.
The retry option is good so that we're more resilient to transient network issues.
There was a problem hiding this comment.
Thanks @joshcooper,
I created #2558 for this and added the flags to the 7x PR as well: https://github.com/puppetlabs/puppet-agent/pull/2556/files#diff-6009cb070484a9435e8b1bc180e82a88330f040e8f8cd0014510c8e56beb8cdcR17
We use '--ignore-dependencies' flag to install wixtoolset since it depends on DotNet3.5 which breaks when installing: wixtoolset/issues#5523. Seems we don't need it for our use case, we can leave it out.