Ubuntu 24.04 Support for BOLT #3376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO this is the wrong approach. This target-specific logic does not belong in apply_prep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on ubuntu24 support for Bolt
Issue
The issue with ubuntu24 is that when running bolt apply the version of puppet-agent that is being pulled is puppet-release-noble.deb and not puppet8-release-noble.deb although other OSes like ubuntu22 work fine, In the case of Ubuntu24 the puppet-release version causes bolt apply to fail.
Solution
My solution is to when running an apply task to first check if the user has specified a collection as an argument in the cli using
collection=<COLLECTION>and if not use Puppet.version to check what version of puppet bolt is using so specifically the puppet-agent install task doesn't default to 'puppet' (pulling the latest ubuntu release) see: install_shell.sh and if all fails default to the latest 'puppet' release version.Testing
I ran acceptance tests with ubuntu2404-64 as the controller and ubuntu2404-64, redhat9-64, fedora40-64 and windows10ent-64 as the nodes and all tests are passing:
Additional notes
I have also updated all GitHub workflows to use ubuntu-24.04 instead of ubuntu-22.04.