(MAINT) WIP User installer for Windows #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chelnak, we were taking a look at this PR during our community sessions and we are unsure whether this one if finished or not (seeing that it still has the WIP in the title). Could you confirm with us if it needs any additional work? |
|
Hey! IIRC it packaged OK at the time. However I don't think it's "complete" if that makes sense which is why I left it with WIP in the title. Maybe try pulling the PR and running it through vanagon to see what happens! Ping if you need anything 🙂 |
|
We will convert this into a draft for the time being and keep it here as a reference for future work. We are not committing just yet to this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a number of changes that attempt to enable building a user based installer for Windows.
Rather than Program Files, the application should get installed in the users local app data therefore not requiring any Administrative privileges.
The changes are a rationalisation of some previous work in a previous PR that got superseded.
While functionally correct, the changes here need to be tested with our build machines.
Additionally, the changes to the project file almost certainly can be refactored in to a more efficient structure.
Enjoy and please ask if you want any clarifications!