Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5998) Add sles11-x86_64 to puppet-runtime #802

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

amitkarsale
Copy link
Contributor

Enforcing runtime build to use latest gcc i.e pl-gcc8

@amitkarsale amitkarsale requested review from a team as code owners March 11, 2024 20:21
pkgconfig
pl-autotools
pl-cmake
pl-gcc8
Copy link
Contributor

@joshcooper joshcooper Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this platform definition is shared by both agent-runtime-7.x and agent-runtime-main, I'm thinking it would be better to install pl-gcc8 in

if platform.name =~ /sles-11-x86_64/ && settings[:ruby_version] =~ /2.7/
pkg.install do
"zypper install -y --oldpackage pl-gcc=4.8.2-1"
end
end
so that we don't install pl-gcc8 for 7.x and then downgrade to an older version. Also keeping both gcc versions in the same place is a plus

@joshcooper joshcooper merged commit 78d1786 into puppetlabs:master Mar 13, 2024
3 checks passed
@joshcooper joshcooper added the skip changelog Will be excluded from changelog label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Will be excluded from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants