Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PA-6145]: Applied Curl Patch CVE-2023-46218 #805

Merged

Conversation

span786
Copy link
Contributor

@span786 span786 commented Mar 18, 2024

Applied Curl Patch CVE-2023-46218 [cookie: lowercase the domain names before PSL checks]

@span786 span786 requested review from a team as code owners March 18, 2024 13:35
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't already, could you try to run vanagon generic builder on a subset of platforms including windows, solaris, aix, mac and linux

@span786
Copy link
Contributor Author

span786 commented Mar 19, 2024

vanagon-generic-builder pipeline links:

  1. agent-runtime-main : Build is failing for solaris-11-sparc because of error (../src/sparc/ffi.c:319:3: error: 'asm' undeclared (first use in this function))
  2. agent-runtime-7.x : Build is failing for aix-7.2-ppc because of error (/bin/sh: /opt/pl-build-tools/bin/gcc: not found)

@span786 span786 requested a review from joshcooper March 19, 2024 14:05
@joshcooper
Copy link
Contributor

@span786 I think you're mixing BUILD_TARGETS from agent-runtime-7.x and agent-runtime-main Unfortunately, they're similar, but not the same, so be sure you're copying the BUILD_TARGETS from the correct agent-runtime-* Init job.

7.x Init
main Init

For Solaris 11 SPARC, we native compile in main, but cross compile in 7.x. So when building agent-runtime-main, you'll want to use this solaris-11-native-sparc, which refers to this platform definintion. This is necessary, because we needed newer gcc and build tools to compile ruby 3.2, etc.

For AIX, agent-runtime-7.x builds on AIX 7.1 while agent-runtime-main builds on AIX 7.2. This is because AIX 7.1 is technically EOL and so we didn't want to start off building puppet 8, ruby 3.2, etc on an EOL platform. Note AIX is like Windows, we build on the oldest supported platform, but install on all supported platforms like 7.2 and 7.3.

@span786 span786 force-pushed the PA-6145-patch-curl-cve-2023-46218 branch from c7d4913 to 885731e Compare March 20, 2024 02:42
@span786 span786 merged commit f23dc6b into puppetlabs:master Mar 20, 2024
3 checks passed
@joshcooper joshcooper added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants