Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PA-6350) Enable agent-runtime main builds for fedora 40 Intel #838

Merged
merged 1 commit into from
Apr 25, 2024
Merged

(PA-6350) Enable agent-runtime main builds for fedora 40 Intel #838

merged 1 commit into from
Apr 25, 2024
+20 −1

Conversation

shubhamshinde360
Copy link
Contributor

@shubhamshinde360 shubhamshinde360 commented Apr 24, 2024 •
edited
Loading

  • Add Fedora 40 (Intel) platform definition file
  • Patch swig generated interface patch for Fedora 40
  • Apply ruby-augeas patch to remove unused sibling parameter for all platform building ruby-augeas. It breaks Fedora 40 and generates a warning for other platforms.

@shubhamshinde360 shubhamshinde360 requested review from a team as code owners April 24, 2024 13:32
@shubhamshinde360
Copy link
Contributor Author

Fedora 40 artifacts available at: https://builds.delivery.puppetlabs.net/puppet-runtime/4722df5f5fb7cc334a6e7fa6ff3126676b95d395/artifacts/

Vanagon generic builder link: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2859/BUILD_TARGET=fedora-40-x86_64,SLAVE_LABEL=k8s-worker/consoleFull

@shubhamshinde360
Copy link
Contributor Author

shubhamshinde360 commented Apr 24, 2024 •
edited
Loading

Ran several platforms for agent-runtime 7x and main at random and they complete without generating the argument mismatch warning:
agent-runtime-7.x: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2864/

agent-runtime-main: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2867/

@shubhamshinde360 shubhamshinde360 marked this pull request as draft April 24, 2024 13:50
@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review April 24, 2024 16:39
@cthorn42
Copy link
Collaborator

Also your 7.x runtime job failed with a AIX failing to build openssl, which really really seems like a transient given these changes. I'm re-running the job here: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2870/.

@shubhamshinde360
Copy link
Contributor Author

@cthorn42 Sorry I just realized AIX 7.2 is not supported in agent-runtime-7.x. We use it to generate agent-runtime-main and AIX 7.1 for 7.x.

@shubhamshinde360
(PA-6350) Enable agent-runtime main builds for fedora 40 Intel
31a0c5f 
 - Add Fedora 40 (Intel) platform definition file
 - Patch swig generated interface patch for Fedora 40
 - Apply ruby-augeas patch to remove unused sibling parameter for all platforms using building ruby-augeas. It breaks Fedora 40 and generates a warning for other platforms.
@shubhamshinde360
Copy link
Contributor Author

shubhamshinde360 commented Apr 24, 2024 •
edited
Loading

AIX-7.1 has passed for agent-runtime-7.x
https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2871/

@cthorn42 cthorn42 merged commit acf6917 into puppetlabs:master Apr 25, 2024
3 checks passed
@joshcooper joshcooper added the enhancement New feature or request label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper left review comments

@cthorn42 cthorn42 cthorn42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamshinde360 @cthorn42 @joshcooper