Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Bump bcrypt gem #854

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

donoghuc
Copy link
Contributor

No description provided.

@donoghuc donoghuc requested review from a team as code owners May 21, 2024 23:13
@donoghuc
Copy link
Contributor Author

So if i understand correctly @h0tw1r3 we dont need to explicitly vendor mingw gems https://rubygems.org/gems/bcrypt_pbkdf/versions/1.1.1 because we do that as a build step? We do that in some cases for ffi, but that is a whole other can of worms.

@h0tw1r3
Copy link
Contributor

h0tw1r3 commented May 21, 2024

So if i understand correctly @h0tw1r3 we dont need to explicitly vendor mingw gems https://rubygems.org/gems/bcrypt_pbkdf/versions/1.1.1 because we do that as a build step? We do that in some cases for ffi, but that is a whole other can of worms.

Correct, and the builds work because the of the fixes between the 1.1.0 release and 1.1.1:

@joshcooper joshcooper merged commit 5df6088 into puppetlabs:master May 22, 2024
3 checks passed
@joshcooper joshcooper added the enhancement New feature or request label May 22, 2024
@donoghuc
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants