Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-38998) Include getoptlong for bolt-server main #893

Merged
merged 1 commit into from
Aug 9, 2024
Merged

(PE-38998) Include getoptlong for bolt-server main #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions configs/components/rubygem-getoptlong.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
component 'rubygem-getoptlong' do |pkg, settings, platform|
pkg.version '0.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.2.1 exists if we want to use that. Puppet's dep is "~> 0.2.0" so it is probably pulling the new version in. But a quick scan of the changes between the two looks unimportant to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wan to make sure i have the same version as the default in our version of ruby.

pkg.md5sum '91760bf343765c5d3f08cb5393d90487'

instance_eval File.read('configs/components/_base-rubygem.rb')
end
4 changes: 4 additions & 0 deletions configs/projects/pe-bolt-server-runtime-main.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
end

instance_eval File.read(File.join(File.dirname(__FILE__), '_shared-pe-bolt-server_with_ruby.rb'))
# These are ruby 3/puppet 8 specific gems. Some of them are "default/standard" gems. There
# is a very annoying issue where default gems can be loaded by MRI but not jruby.
# We explicitly pacakge up some default gems where we have explicit dependencies for jruby
proj.component 'rubygem-prime'
proj.component 'rubygem-rexml'
proj.component 'rubygem-getoptlong'
end
Loading