Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PUP-11655) Use run_mode for better platform independence #8938

Closed
wants to merge 1 commit into from
Closed

(PUP-11655) Use run_mode for better platform independence #8938

wants to merge 1 commit into from

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Oct 14, 2022

Splitting off the compatible changes from #8636 to make it easier to review.

@ekohl ekohl requested a review from a team as a code owner October 14, 2022 14:09
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@ekohl ekohl mentioned this pull request Oct 14, 2022
Draft
@mhashizume
Copy link
Contributor

Hi @ekohl ! Thanks for the contribution. Could you rebase your PR and retarget to 7.x? You may also need to close and re-open this PR to pick up the right GitHub checks.

Thank you!

@ekohl ekohl changed the base branch from main to 7.x April 25, 2023 20:24
@ekohl
Copy link
Contributor Author

ekohl commented Apr 25, 2023 •
edited
Loading

The retarget + rebase (in that order) appears to have worked since checks are started. Please take a look if they're the right tests.

@cthorn42
Copy link
Collaborator

@ekohl sorry it has taken our team so long to get around to looking at this. Is this something that is still a priority to you that we should look into?

@joshcooper
Copy link
Contributor

Rekicking specs

@joshcooper joshcooper closed this Oct 10, 2023
@joshcooper joshcooper reopened this Oct 10, 2023
@ekohl
(PUP-11655) Use run_mode for better platform independence
c5fc8fb 
The run mode already determines the platform. Moving all platform
specific paths into RunMode makes it easier to get a complete overview
and change things where needed.
@ekohl
Copy link
Contributor Author

ekohl commented Oct 10, 2023

@ekohl sorry it has taken our team so long to get around to looking at this. Is this something that is still a priority to you that we should look into?

I can hardly say it's a priority now, but I do feel this would be good to have. The whole idea behind this was that it will be easier for distros to package using non-AIO without having to patch a lot. This specific PR is scoped to just refactor things without changing anything. If this is accepted, there's still more to do but it's a start.

@ekohl
Copy link
Contributor Author

ekohl commented Oct 10, 2023

And I see there's another failure. Will need to look at it later.

@joshcooper joshcooper added the enhancement New feature or request label Nov 15, 2023
@joshcooper joshcooper mentioned this pull request Mar 13, 2024
Merged
@joshcooper
Copy link
Contributor

Thanks @ekohl, I'm going to close this in favor of #9294

@joshcooper joshcooper closed this Mar 13, 2024
@ekohl ekohl deleted the PUP-11655 branch March 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekohl @puppetlabs-jenkins @mhashizume @cthorn42 @joshcooper