Correct Red Hat service providers #9212
Conversation
mhashizume
force-pushed
the
maint/main/systemd-fixup
branch
3 times, most recently
from
6b91436 to
93f6b56
Compare
|
jenkins please test this on almalinux8-64a,amazon7-64a,amazon2023-64a,amazon2023-AARCH64a,redhat7-64a,redhat8-64a,redhat8-POWERa,redhat9-64a,redhat9-AARCH64a,redhatfips7-64a,redhatfips8-64a,rocky8-64a |
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| commands :chkconfig => "/sbin/chkconfig", :service => "/sbin/service" | |||
|
|
|||
| defaultfor 'os.family' => :redhat | |||
| defaultfor 'os.name' => :amazon, 'os.release.major' => ["2017"] | |||
There was a problem hiding this comment.
I found that Amazon Linux 1 may report the major version as 2018, so maybe add 2018 to the array and the notdefaultfor in the systemd provider.
I think this overall change may be breaking on RedHat (or derivative) for some esoteric combinations of:
- systems (excluding SUSE 10/11, AL1 and RHEL4-6) which don't use systemd. Though that list is basically empty.
- systems where
systemdis not available due to theconfine :trueline above, see 93ca5f0. Going back in history it looks like it was previously updated to support puppet running in achrootenvironment a7b9d0e, and before that, the line was added forDebianin c36f1e9
So maybe the entire backwards compat issue doesn't matter?
There was a problem hiding this comment.
Thanks for the review Josh. I updated the Amazon Linux statements (their versioning scheme can be confusing . . . ).
Given what you've found, I agree that platforms potentially affected by this change seem very limited, probably esoteric, and definitely not officially supported anyway.
SystemD has been the default init system for Red Hat Enterprise Linux and its derivatives since RHEL 7 was released in 2014. In 928cf67, we attempted to reflect this in Puppet's service providers. However, this change did not have the desired effect as the RedHat service provider was still specified as the default for systems with the os.family fact of "redhat." Tests relating to services started failing after 928cf67. I do not believe that this change will have any undesired effects on Red Hat derivatives like Alma or Rocky because those distributions also use SystemD as their init system and use the same versioning scheme as upstream.
mhashizume
force-pushed
the
maint/main/systemd-fixup
branch
from
93f6b56 to
04b01e2
Compare
SystemD has been the default init system for Red Hat Enterprise Linux and its derivatives since RHEL 7 was released in 2014. In 928cf67, we attempted to reflect this in Puppet's service providers.
However, this change did not have the desired effect as the RedHat service provider was still specified as the default for systems with the os.family fact of "redhat." Tests relating to services started failing after 928cf67.
I do not believe that this change will have any undesired effects on Red Hat derivatives like Alma or Rocky because those distributions also use SystemD as their init system and use the same versioning scheme as upstream.