Fix performance cops #9230
Merged
Fix performance cops #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.7 introduced Enumerable#filter_map that allows elements of an
enumerable block to be transformed and remove falsy results. This commit
updates all instances of collect/map { ... }.compact with filter_map.
This was identified by the Rubocop Performance/MapCompact cop.
This commit replaces an instance of bind(obj).call(args) with the more performance bind_call(obj, args) method introduced in Ruby 2.7. This was identified by the Rubocop Performance/BindCall cop.
tvpartytonight
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises fixes to Rubocop performance cop violations to support updating Rubocop and its extensions in #9222