fix(puppet-agent): Fixes #9208 - puppet agent windows daemon startup inconsistency. #9338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
|
…n startup inconsistency
vibe
force-pushed
the
fix/puppet-agent-windows-daemon-startup
branch
from
847d7ae to
33fe1df
Compare
|
Thanks for submitting this patch @vibe , I only had a small suggestion to address for this. I am going to look into adding some testing around this change to get some additional confirmation it is working as intended. |
|
@tvpartytonight Sorry I missed these comments was logged into my other GitHub account. Looks you got this merged in with #9386 along with some tests. This is great news! |
|
Thank you for your contribution @vibe! This will be included in the next 7.x and 8.x releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues.
#9208 Puppet 8.x service not starting as expected on Windows.
puppetlabs/puppet-agent#2459
Thanks to this comment in the
windows/daemon.rbfile, I found similar issues and conversations.chef/win32-service#84
We have a validated the fix works as expected across various different machine/setups.