Skip to content

Conversation

nrhall
Copy link

@nrhall nrhall commented May 2, 2025

Summary

Providing Sensitive(Deferred(...)) inputs to concat::fragment (where the deferred function returns a String) does not work in concat::fragment.

Additional Context

Given that Deferred types do work, it seems reasonable to allow these to also be Sensitive so you can handle things like secrets from Vault, or Sensitive deferred templates - however currently, concat::fragment only allows Sensitive[String], which can't be determined at compile time when there's a Deferred function to resolve.

This PR generalises it to allow just Sensitive; I appreciate this weakens the type-checking slightly, but allowing Deferred already seems to have similar issues (because you can't tell that it's a Deferred[String]), so hopefully this is acceptable.

Checklist

  • 🟢 Spec tests.
  • [ x ] 🟢 Acceptance tests.
  • [ x ] Manually verified. (For example puppet apply)

@nrhall nrhall requested review from b4ldr, bastelfreak, ekohl, smortex and a team as code owners May 2, 2025 16:48
@CLAassistant
Copy link

CLAassistant commented May 2, 2025

CLA assistant check
All committers have signed the CLA.

@nrhall
Copy link
Author

nrhall commented Sep 19, 2025

Hi - wondered if anyone had a chance to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants