Fix puppet-lint space_before_arrow violation in mysqlbackup.pp - #1731
Merged
Conversation
The `require` parameter in the `mysql_user` resource block in
`manifests/backup/mysqlbackup.pp` had multiple spaces before `=>`
to align it with the other parameters above it:
require => Class['mysql::server::root_password'],
While visually consistent with the aligned parameters above it,
puppet-lint's `space_before_arrow` check enforces exactly one space
before `=>` in all cases. This was causing the spec/lint CI step to
fail with:
WARNING: there should be a single space before '=>' on line 48,
column 11 (check: space_before_arrow)
Error: Process completed with exit code 1.
This is a pre-existing issue in the codebase unrelated to any recent
changes — it would cause the lint step to fail on any PR's CI run.
Fix: remove the extra spaces so `require` follows the same single-space
convention as all other `=>` arrows in the file.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bronachfalls
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
August 18, 2026 08:54
david22swan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
requireparameter in themysql_userresource block inmanifests/backup/mysqlbackup.pphad multiple spaces before=>to align it with the other parameters above it:While visually consistent with the aligned parameters above it, puppet-lint's
space_before_arrowcheck enforces exactly one space before=>in all cases. This was causing the spec/lint CI step to fail with:This is a pre-existing issue in the codebase unrelated to any recent changes — it would cause the lint step to fail on any PR's CI run.
Fix: remove the extra spaces so
requirefollows the same single-space convention as all other=>arrows in the file.Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)