Skip to content

Fix puppet-lint space_before_arrow violation in mysqlbackup.pp - #1731

Merged
david22swan merged 1 commit into
mainfrom
fix/mysqlbackup-space-before-arrow
Aug 18, 2026
Merged

Fix puppet-lint space_before_arrow violation in mysqlbackup.pp#1731
david22swan merged 1 commit into
mainfrom
fix/mysqlbackup-space-before-arrow

Conversation

@bronachfalls

Copy link
Copy Markdown
Contributor

The require parameter in the mysql_user resource block in manifests/backup/mysqlbackup.pp had multiple spaces before => to align it with the other parameters above it:

require       => Class['mysql::server::root_password'],

While visually consistent with the aligned parameters above it, puppet-lint's space_before_arrow check enforces exactly one space before => in all cases. This was causing the spec/lint CI step to fail with:

WARNING: there should be a single space before '=>' on line 48,
column 11 (check: space_before_arrow)
Error: Process completed with exit code 1.

This is a pre-existing issue in the codebase unrelated to any recent changes — it would cause the lint step to fail on any PR's CI run.

Fix: remove the extra spaces so require follows the same single-space convention as all other => arrows in the file.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

The `require` parameter in the `mysql_user` resource block in
`manifests/backup/mysqlbackup.pp` had multiple spaces before `=>`
to align it with the other parameters above it:

    require       => Class['mysql::server::root_password'],

While visually consistent with the aligned parameters above it,
puppet-lint's `space_before_arrow` check enforces exactly one space
before `=>` in all cases. This was causing the spec/lint CI step to
fail with:

    WARNING: there should be a single space before '=>' on line 48,
    column 11 (check: space_before_arrow)
    Error: Process completed with exit code 1.

This is a pre-existing issue in the codebase unrelated to any recent
changes — it would cause the lint step to fail on any PR's CI run.

Fix: remove the extra spaces so `require` follows the same single-space
convention as all other `=>` arrows in the file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@david22swan
david22swan merged commit 46ab224 into main Aug 18, 2026
18 of 20 checks passed
@david22swan
david22swan deleted the fix/mysqlbackup-space-before-arrow branch August 18, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants