stdlib::manage: Also permit templates for concat::fragment #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl,
seanmil and
smortex
as code owners
jcpunk
force-pushed
the
concat-fragment
branch
from
f6d7771 to
8e21ed7
Compare
|
Maybe adding some tests would help? |
jcpunk
force-pushed
the
concat-fragment
branch
from
8e21ed7 to
6bacf75
Compare
|
Detailed tests added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds limited template support for
concat::fragmentresources under stdlib::manageAdditional Context
Add any additional context about the problem here.
It might be nice to divide /etc/motd up via
concatand defer some limited elements into trivial yaml.Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)