Skip to content

Fix jdbc provider params management #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix jdbc provider params management #260

wants to merge 13 commits into from

Conversation

@biamandei
Copy link
Collaborator

@biamandei biamandei commented Jan 9, 2023 •
edited
Loading

This fixes and enhances the JDBC provider type:

  1. FIX: ability to create a new JDBC provider
  2. ENHANCE: ability to delete an existing JDBC provider
  3. ENHANCE: ability to manage an existing JDBC provider
  4. ENHANCE: composite namevars for the type

biamandei added 13 commits January 9, 2023 23:00
@biamandei
Add composite namevars for the type
9bfec61 
Tidy up params/validation
Add extra params to type
Improve create() method
Add destroy() method
Add/improve flush() method

JDBC Providers can now be controlled entirely out of this type
@biamandei
Fix ternary operator syntax
d4155c0
@biamandei
Fix:
4ce2e24 
running destroy() code, and
missing end at flush()
@biamandei
Debugging
097771f
@biamandei
Fix xml_file target for exists()
501f699
@biamandei
Set insync() method for array properties
8a9c858 
Set classpath and nativepath to be array arguments.
@biamandei
Use the correct param: providertype
6240f1c 
Enable validtion of incompatible arguments:
* isolated_class_loader
* nativepath
@biamandei
Build classpath and nativepath the way WAS likes it
adc5216
@biamandei
Ensure we run flush() only when we need to
0cdb46f
@biamandei
Add support for managing isolated class loader status
c29f559
@biamandei
Fix containment path specs for resource creation
3b873d3
@biamandei
Some extra debug on exists?() method
ef20dc3
@biamandei
Some extra debug on exists?() method
8bbc724
@biamandei biamandei requested a review from a team as a code owner January 9, 2023 12:06
@puppet-community-rangefinder
Copy link

puppet-community-rangefinder bot commented Jan 9, 2023

websphere_jdbc_provider is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@biamandei @CLAassistant @ia-content