(PA-6263) Add amazon linux2 to pxp-agent 7.x and bump cmake #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkarsale
force-pushed
the
PA-6263
branch
3 times, most recently
from
8faceca to
d8fa0f0
Compare
joshcooper
approved these changes
May 8, 2024
There was a problem hiding this comment.
nit, the vanagon generic build used a fork of the packaging repo:
10:17:30 Using vanagon 0 from [email protected]:imaqsood/vanagon (at PA-6262-cmake3-changes@055c817)
I try to use same set of dependencies in vanagon generic builder that CI uses to avoid surprises. But this seems straightforward and vanagon 0.50 was released, so I'm 👍
amitkarsale
changed the title
|
re-ran the generic builder with cmake update and updated the vanagon generic builder link with the latest run. Just FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AL2 platform definition added for 7.x
vanagon generic builder : https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2938/