Conversation
exec-path-from-shell.el
Outdated
| (setq values (cdr values) | ||
| names (cdr names)))) | ||
| result))) | ||
| (if (exec-path-from-shell--nushell-p) |
There was a problem hiding this comment.
This is the only thing I found that didn't work in the PR. This function seems to take an argument (the shell) but that is missing here. I tried adding the argument in my local copy as (exec-path-from-shell--shell) and after that it was working pretty much perfect, including getting additional environment variables from the nushell env.
There was a problem hiding this comment.
Ah, silly mistake when I tied it together at the last minute then. Thanks for the feedback. I'll fix that issue and merge, then you can see how you get along with the MELPA version.
|
I didn't know how else to leave a comment at the correct line, so I may have started a review...sorry about that. But yes, as the comment says, everything works after we pass in the shell as the argument to the |
|
(P.S. the way to create a plain comment is to click the other button: the default green one is labelled "Start a review", the other says "Comment". I make this mistake all the time myself.) |
2 participants
See #109.
Currently a bit of a messy addition, but good enough to try out. Works by asking
nuto print the relevant env vars as JSON, then Emacs parses the result. This is actually cleaner than theprintfapproach. Certain vars (e.g. PATH) are arrays insidenu, so we artificially join them back into a single string withpath-separator(usually:) so that the result lines up with that from other shells.