util: Test

[ahmad-abuziad]

The goal of this PR to test cover util/util.go and increase it from 64.8% to 100% since almost all the util functions are testable

[purpleidea]

These will keep failing because of the commit message. Look at the tests. Lmk if you need more help.

[ahmad-abuziad]

These will keep failing because of the commit message. Look at the tests. Lmk if you need more help.

I will look into it.
I will stick with the format since i started with it, except the last commit will contain a message that doesn't fail.

[purpleidea]

You can easily rename a bunch with: EDITOR=vim git rebase -i <commit id before the first one>

[ahmad-abuziad]

coverage increased from 64.8% to 94.4

[purpleidea]

Thanks for all the tests.

For a first start, can you please rename the commit messages so they have the right format, typically util: Test blah blah... in this case.

Next see the other misc things, then we'll do a final review. Thank you!

Sorry for the delay, I've been at the FOSDEM+CfgMgmtCamp conference stuff.

[purpleidea]

I expect to still see failures, test is here: https://github.com/purpleidea/mgmt/blob/master/test/test-commit-message.sh#L17

So for example a valid commit is:

foo: Hello something

an invalid commit is:

foo: hello something

Note the capitalization.