forked from google/skia
-
Notifications
You must be signed in to change notification settings - Fork 0
Canvas kit pdf #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pushpagarwal
wants to merge
45
commits into
canvaskit-pdf-kartik-review
Choose a base branch
from
canvas-kit-pdf
base: canvaskit-pdf-kartik-review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://chromium.googlesource.com/vulkan-deps.git/+log/62162b8f056a..827e0dba01ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: Ibb715be4d39aab9db7f066e321e1e8d7512ef443 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023336 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
Change-Id: Iffea348275b07cbb710f2f49271e72be5206098d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1022736 Auto-Submit: Matt Stark <[email protected]> Commit-Queue: Matt Stark <[email protected]> Reviewed-by: Nicolette Prevost <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/827e0dba01ad..c8bd17b0ce68 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/105d6c1fede00c3a9055e5a531ebf3d99bac406e..36f2e7584258bea0b6d71aed7108f5afe11ea494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: Ib869795c080dbdea4e3c11129c1881847d054a5e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023476 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8708766729109137057 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/dd6e72e9681827a40b81c5f0027dd6f6b54e925a dd6e72e ([email protected]) Update the dependency sufficiency logic to allow for `Revision:... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. [email protected] Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I9e0fd221e1baca8a0d94abdbc60847089a2af71d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023556 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/382fe7d5f3d0..4a7db687eea1 2025-07-18 [email protected] Update child rows hidden check in the anomalies table. 2025-07-18 [email protected] [attest] Include google_cloud_sdk in container 2025-07-18 [email protected] [attest] Add entry to skia.org.zone 2025-07-18 [email protected] [attest] Log the output of the gcloud command 2025-07-18 [email protected] Roll Skia Infra CIPD packages from 1198e6ff0d0c to 382fe7d5f3d0 (6 revisions) 2025-07-18 [email protected] Roll Depot Tools from 5e6b39291412 to ca953c9fccc3 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: Ia249f3e079e0b1afe73106dbf50fc9881c5a2dfe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023576 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/6a04a50f98ca..faf1bb4b3e72 2025-07-18 [email protected] Tests: Add Wuthering Waves trace 2025-07-18 [email protected] Vulkan: Reformat VVL Error Message 2025-07-18 [email protected] Roll vulkan-deps from 286b9f0629a4 to 03f51f594fdd (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: [email protected] Test: Test: angle_trace_tests --gtest_filter=TraceTest.wuthering_waves Change-Id: I44afc0d82b26f2eeb1fa7c45513d177c57d5a318 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023478 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/81e90f7fd7f3..2502261c4 This also requires updating abseil. Note that it's Dawn's GN files that are used to build abseil, which were updated in https://dawn-review.googlesource.com/c/dawn/+/253214 https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9c3ff1b50b60262..cae4b6a3990e Change-Id: Ia5dad832cb113e7a44fee32718412867bb6d4d8d Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: b/432742366 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023098 Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Julia Lavrova <[email protected]>
Change-Id: Ic2aaed096397a9f71515148d2fb329be6a705cf2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1021716 Reviewed-by: Eric Boren <[email protected]> Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Mike Reed <[email protected]>
https://review.skia.org/1019977 has accidentally rearranged the order in which 2 pieces of code execute: * Verification that `IHDR`'s width and height is less than `kMaxPNGSize` * Converting width from `u32` to `i32` in `CreateEncodedInfo` To prevent this from happening, this CL puts those 2 pieces of code right next to each other (i.e. moving the `kMaxPNGSize` verification into the body of `CreateEncodedInfo`). Bug: chromium:432516335 Change-Id: I4e289337b362e54b735d48d3f4d22f47971c3d3b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023099 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Łukasz Anforowicz <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/c8bd17b0ce68..af70cb4dfd93 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/36f2e7584258bea0b6d71aed7108f5afe11ea494..f766b30b2de3ffe2cf6b656d943720882617ec58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: Ieb8f024991f9007bb0134b66f6ffad5615ee0f44 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023798 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia-review.googlesource.com/c/skia/+/1015997 did not allow already subpixel draws to be combined with clip geometry, but did not restrict the clip+draw intersection from producing a subpixel draw. This fixes the clipped_thinrects GM on gold. Bug: b/424508534 Change-Id: I58811e5d15e3e749b03589e8102281ae281cc7f9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023316 Reviewed-by: Thomas Smith <[email protected]> Commit-Queue: Michael Ludwig <[email protected]> Reviewed-by: Robert Phillips <[email protected]>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8708718286071451297 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2ce1727fb76c6598dc25e06e9b1e0cb7a499dba2 2ce1727 ([email protected]) Roll CAS Client from cc107e82186b to 2ee988d9650e Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. [email protected] Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ie2fa97acb9290b6f381dd9d52a8bb0f5a981bddf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023956 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This should fix the perf regressions introduced from the inner bounds CL shown in https://skia-perf.luci.app/e/?begin=1750917470&enable_chart_tooltip=true&end=1753099846&keys=Xe26b184787f69bc459d2de2d8f2470da&plotSummary=true&show_google_plot=true&use_titles=true&xbaroffset=75803&request_type=0 With the inner bounds change, when a clip and a draw both contained each other (e.g. they were the same rectangle), the b.contains(a) check would now pass with the early inner bounds test and we'd return kReplacesDraw instead of kNone for the influence. But before https://skia-review.googlesource.com/c/skia/+/1015997 landed, this was handled as if the clip intersected the shape now. While the clip+draw modifications resolved a lot of the regressions by intersecting the clip directly, it's better to just prefer treating these situations as unclipped. Bug: b/424506312 Change-Id: I9932902a8296fe004eb98ef586bbfc59a4d5bb3e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023296 Reviewed-by: Thomas Smith <[email protected]> Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
Change-Id: Ifc6c533d0c104264d555b1c424cd399063a319f0 Bug: b/367315534 No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024036 Reviewed-by: Eric Boren <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Commit-Queue: Eric Boren <[email protected]>
Fixes xfermodes3 GM, where a clear blend mode is the same as a transparent clear, regardless of the paint. Also fixes logic for analyzing the primitive blender, since that doesn't impact the dst blend, it just impacts whether or not we know the src is opaque. Re-arranges the logic to only calculate whether or not the src is opaque if we need it (for src-over and now, dst-out). Change-Id: Ieca75b9dba34fe91394c10461317f3ba3352a399 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023376 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
Without this check, a drawPaint() call that was inside a clipRect() would incorrectly trigger a discard. Bug: b/424509730 Change-Id: I7b20560898b499d67830f1468c0fc520f48d1b16 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023897 Commit-Queue: Robert Phillips <[email protected]> Auto-Submit: Michael Ludwig <[email protected]> Reviewed-by: Robert Phillips <[email protected]>
The miter limit and cap outset can be significant, which must be accounted for in arbitrary stroked path bounds, but it can easily cause stroked [r]rects and lines to be clipped when they shouldn't be. This was noticed while investigating the performance regressions from https://skia-review.googlesource.com/c/skia/+/1015960. While the bounds issue was always present, the tight scissor avoided analytic clipping and with a loose scissor, it triggered more costly clipping. With tight bounds, it correctly detects that no clipping is needed. Bug: b/424510276 Change-Id: I980f2a8c7d904155f6d6de060147607bed628bea Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1023317 Commit-Queue: Michael Ludwig <[email protected]> Reviewed-by: Thomas Smith <[email protected]> Reviewed-by: Robert Phillips <[email protected]>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8708708219982692049 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/75449d2000f1bbfdae9e5cfbc13bedac876fa6b0~..9ed8f258014ad69d31c5ab663e01c9568c7ed3f7 75449d2 ([email protected]) mcp: Add some buildbucket tools and the mcp server 9ed8f25 ([email protected]) Revert "Roll git-credential-luci to build with U2F support" Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. [email protected] Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: If49d354d48e1c8530648dd10ccec6f6749b20d28 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024096 Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Follow-up from https://skia-review.googlesource.com/c/skia/+/896098/13/infra/bots/jobs.json#b17 Change-Id: I7f9d3860ba2cedebe55523dfdf1d80d4387f2d46 Bug: b/40044159 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024156 Auto-Submit: Kaylee Lubick <[email protected]> Commit-Queue: Eric Boren <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Reviewed-by: Eric Boren <[email protected]>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8708688087129010289 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2d880d2ff3ccd2c3ce95e02dcc6fd61a5636252a 2d880d2 ([email protected]) Roll CAS Client from 965a8983b839 to c5f206105bc4 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. [email protected] Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I5b861f9450ebc1718ffcf95e9d6645e567405b42 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024416 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/2502261c4d1a..6492a9924110 2025-07-22 [email protected] [tint] Loop Analysis: Support `GreaterThanEqual` operator 2025-07-21 [email protected] Roll SwiftShader from 65b2c4777e5f to dbe5742b8639 (1 revision) 2025-07-21 [email protected] [exit-time-destructors] kBenchmarkInputs as no-destructor 2025-07-21 [email protected] [ir] Add IR extension documentation. 2025-07-21 [email protected] Add missing detail for supported compilers, sdk 2025-07-21 [email protected] [dawn][opengl] Support combined samplers for binding_array 2025-07-21 [email protected] Roll ANGLE from faf1bb4b3e72 to 61c609c8e641 (1 revision) 2025-07-21 [email protected] [dawn][native] Allow setting default values in DAWN_SERIALIZABLE. 2025-07-21 [email protected] Add e2e tests for Tier1 storage texture access 2025-07-21 [email protected] Range Analysis: Compute range of built-in call `max` 2025-07-21 [email protected] [tint] Loop Analysis: Support `LessThanEqual` operator 2025-07-21 [email protected] [tint] Run `Robustness` transform before `PreventInfiniteLoops` 2025-07-20 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU Compat CTS expectations 2025-07-20 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations 2025-07-19 [email protected] Roll ANGLE from 41bfed391867 to faf1bb4b3e72 (2 revisions) 2025-07-19 [email protected] Expectation for mac intel sequoia and a too-many-d3d-devices problem 2025-07-19 [email protected] [cts] triage intel win i32 remainder CTS failures 2025-07-18 dawn-automated-expectations@chops-service-accounts.iam.gserviceaccount.com Roll third_party/webgpu-cts/ 6185b7a62..5b477670f (10 commits) 2025-07-18 [email protected] Roll ANGLE from 6a04a50f98ca to 41bfed391867 (1 revision) 2025-07-18 [email protected] Bulk fixing license metadata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Test: Test: tint_unittests Change-Id: Id51edfa9f49834f83d8c99123ab0da63614dc542 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024277 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/4a7db687eea1..a898e8056b2f 2025-07-22 [email protected] Temporary fixed performance issue when pre-generating multi graph url 2025-07-21 [email protected] Use newer alpine version 2025-07-21 [email protected] Enable prometheus monitoring for mcp service 2025-07-21 [email protected] Remove cockroachdb related code from Perf 2025-07-21 [email protected] [attest] Add a bare-bones binaryauthorization API client 2025-07-21 [email protected] Update the async api call response that calls to fetchGroupReport api tp prevent null response being returned. 2025-07-21 [email protected] Reland "Update child rows hidden check in the anomalies table." 2025-07-21 [email protected] Revert "Fix the race condition to cause api call run simultaneously." 2025-07-21 [email protected] Revert "Update child rows hidden check in the anomalies table." 2025-07-21 [email protected] Roll Skia Infra CIPD packages from 382fe7d5f3d0 to 4a7db687eea1 (6 revisions) 2025-07-21 [email protected] Roll Depot Tools from ca953c9fccc3 to dd6e72e96818 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I748c76fc4e3a342589502ac7a7dc9d5cf5d67d18 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024417 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://swiftshader.googlesource.com/SwiftShader.git/+log/65b2c4777e5f..084f9893520c 2025-07-21 [email protected] Make llvm-16.0 Chromium build warning free 2025-07-21 [email protected] Use standard SPDX license identifier in README.chromium 2025-07-21 [email protected] Regres: Update test lists @ 65b2c477 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Ubuntu24.04-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: [email protected] Change-Id: Icdb4d18d8c33b2f040caf305e4b0f1301df33339 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024279 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/af70cb4dfd93..0830f159cb89 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/257a227fbadf8176ea386c7d8fb9b889cbf08640..8cf1bf9bb922e33135e6e343a566764015da2dc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: Iafc5760e494328a99b2f934d1a53627b124aeaa1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024301 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/faf1bb4b3e72..239763d96a4b 2025-07-21 [email protected] CL/VK: Fix ArgumentWorkgroup setArg logic 2025-07-21 [email protected] Translator: Remove Sampler2DRectShadow 2025-07-21 [email protected] Change the way we get vkEnumerateInstanceExtensionProperties 2025-07-21 [email protected] Fix VK-GL-CTS build error 2025-07-21 [email protected] Vulkan: Add support for built-in gl_ShadingRateEXT 2025-07-21 [email protected] Roll VK-GL-CTS from 2a90cff9718b to 368ac769be44 (2 revisions) 2025-07-21 [email protected] Roll vulkan-deps from 03f51f594fdd to 115cdec98cc6 (13 revisions) 2025-07-21 [email protected] Roll VK-GL-CTS from 73db56e823f8 to 2a90cff9718b (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: [email protected] Change-Id: I6701c265eb2661671b7e901047bce64360470bd7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024280 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8708664178838075953 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3bdbcc9bf7966db2f82fcecc45ce0fdeb4285460 3bdbcc9 ([email protected]) Roll CAS Client from 74cfd9210880 to ce380e662ce9 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. [email protected] Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I7971866a8e8df81eff7e991fcdde617991047c0d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1024596 Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1. Reverting all changes outside canvaskit module. 2. Use CacheOrCopy for strings, it would avoid copying strings from JS to WASM and furthe copy in WASM. It adds some memory consumption but attribute owner, name gets repeated often across the tree so that is good tradeoff 3. Now we don't expose stream interface but Document returns buffer on close.
6784490 to
88625ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.