Skip to content

refactor: refactor scopedTranslationSystem - #780

Draft
kcinay055679 wants to merge 4 commits into
mainfrom
feature/refactor-scoped-translation-core
Draft

refactor: refactor scopedTranslationSystem#780
kcinay055679 wants to merge 4 commits into
mainfrom
feature/refactor-scoped-translation-core

Conversation

@kcinay055679

Copy link
Copy Markdown
Collaborator

No description provided.

@kcinay055679 kcinay055679 self-assigned this Aug 6, 2026
@kcinay055679
kcinay055679 marked this pull request as draft August 6, 2026 07:54
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ PR Governance Notice
No linked issue found. This PR will not be moved on the project board automatically.

1 similar comment
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ PR Governance Notice
No linked issue found. This PR will not be moved on the project board automatically.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Frontend Test Results

  1 files  ± 0   52 suites  +1   55s ⏱️ +7s
335 tests +40  313 ✅ +18  0 💤 ±0  22 ❌ +22 
337 runs  +40  315 ✅ +18  0 💤 ±0  22 ❌ +22 

For more details on these failures, see this check.

Results for commit 85f3bb2. ± Comparison against base commit edc113e.

This pull request removes 8 and adds 48 tests. Note that renamed tests count towards both.
ScopedTranslationService getKeyList should return [A.B, B] for prefix "A" and suffix "B" ‑ ScopedTranslationService getKeyList should return [A.B, B] for prefix "A" and suffix "B"
ScopedTranslationService getKeyList should return [A.B.C.D.E, A.B.D.E, A.D.E, D.E] for prefix "A.B.C" and suffix "D.E" ‑ ScopedTranslationService getKeyList should return [A.B.C.D.E, A.B.D.E, A.D.E, D.E] for prefix "A.B.C" and suffix "D.E"
ScopedTranslationService getKeyList should return [B] for prefix "" and suffix "B" ‑ ScopedTranslationService getKeyList should return [B] for prefix "" and suffix "B"
ScopedTranslationService getStringVariations should return 1 variation for prefix "" and key "B" ‑ ScopedTranslationService getStringVariations should return 1 variation for prefix "" and key "B"
ScopedTranslationService getStringVariations should return 1 variation for prefix "A" and key "B" ‑ ScopedTranslationService getStringVariations should return 1 variation for prefix "A" and key "B"
ScopedTranslationService getStringVariations should return 3 variations for prefix "A.B.C" and key "D.E" ‑ ScopedTranslationService getStringVariations should return 3 variations for prefix "A.B.C" and key "D.E"
ScopedTranslationService instant should call proper methods  ‑ ScopedTranslationService instant should call proper methods 
ScopedTranslationService should be created ‑ ScopedTranslationService should be created
ScopedTranslationCoreService candidate probing probes candidates in the order the path returned them ‑ ScopedTranslationCoreService candidate probing probes candidates in the order the path returned them
ScopedTranslationCoreService candidate probing probes without params, so a miss never interpolates ‑ ScopedTranslationCoreService candidate probing probes without params, so a miss never interpolates
ScopedTranslationCoreService candidate probing returns the resolved translation ‑ ScopedTranslationCoreService candidate probing returns the resolved translation
ScopedTranslationCoreService candidate probing stops at the first hit ‑ ScopedTranslationCoreService candidate probing stops at the first hit
ScopedTranslationCoreService delegation to the key path asks the path for candidates of the requested key ‑ ScopedTranslationCoreService delegation to the key path asks the path for candidates of the requested key
ScopedTranslationCoreService delegation to the key path builds the path from the given prefix ‑ ScopedTranslationCoreService delegation to the key path builds the path from the given prefix
ScopedTranslationCoreService delegation to the key path defaults the prefix to the root scope ‑ ScopedTranslationCoreService delegation to the key path defaults the prefix to the root scope
ScopedTranslationCoreService delegation to the key path does not ask for the fallback on a hit ‑ ScopedTranslationCoreService delegation to the key path does not ask for the fallback on a hit
ScopedTranslationCoreService interpolation re-reads on empty params, since undefined is the only opt-out ‑ ScopedTranslationCoreService interpolation re-reads on empty params, since undefined is the only opt-out
ScopedTranslationCoreService interpolation re-reads only the winner with params ‑ ScopedTranslationCoreService interpolation re-reads only the winner with params
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant