Skip to content

feat: map member directly to roles #581 - #792

Draft
fstreit1 wants to merge 71 commits into
mainfrom
feature/581-map-member-directly-to-roles
Draft

feat: map member directly to roles #581#792
fstreit1 wants to merge 71 commits into
mainfrom
feature/581-map-member-directly-to-roles

Conversation

@fstreit1

@fstreit1 fstreit1 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@fstreit1 fstreit1 linked an issue Aug 10, 2026 that may be closed by this pull request
Technical Story: Map Member directly to roles #581
Open
6 tasks
@fstreit1 fstreit1 self-assigned this Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Frontend Test Results

  1 files  ±0   54 suites  +1   51s ⏱️ ±0s
308 tests +2  307 ✅ +1  0 💤 ±0  1 ❌ +1 
311 runs  +2  310 ✅ +1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 6d4928d. ± Comparison against base commit ac0b848.

♻️ This comment has been updated with latest results.

@fstreit1 fstreit1 changed the title Feature/581 map member directly to roles feat: 581 map member directly to roles Aug 11, 2026
@fstreit1 fstreit1 changed the title feat: 581 map member directly to roles feat: map member directly to roles #581 Aug 11, 2026
@github-actions

github-actions Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Backend Test Results

0 tests   - 766   0 ✅  - 766   0s ⏱️ -58s
0 suites  -  66   0 💤 ±  0 
0 files    -  66   0 ❌ ±  0 

Results for commit 7709116. ± Comparison against base commit ac0b848.

♻️ This comment has been updated with latest results.

MasterEvarior
MasterEvarior previously approved these changes Aug 22, 2026
View reviewed changes

@MasterEvarior MasterEvarior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hibernate/JPA issue should be fixed with using Set<> instead of list. This is because of some funky JPA/Hibernate behavior.

Some of the tests will still fail but that may just be the test data that is wrong in some way.

Comment thread backend/src/main/java/ch/puzzle/pcts/controller/CalculationController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/CalculationController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/MemberController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/member/MemberInputDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/member/MemberDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberrole/MemberRole.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/role/Role.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/business/CalculationBusinessService.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/business/MemberBusinessService.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/business/RoleBusinessService.java Outdated
schiltpuzzle
schiltpuzzle requested changes Aug 24, 2026
View reviewed changes

@schiltpuzzle schiltpuzzle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend looks good 👍. frontend needs some work

Comment thread frontend/src/app/features/member/detail-view/member-detail-view.component.ts Outdated
Comment thread frontend/src/app/features/member/detail-view/member-detail-view.component.ts
Comment thread frontend/src/app/features/member/form/member-form.component.ts Outdated
Comment thread frontend/src/app/features/member/detail-view/member-detail-view.component.ts Outdated
Comment thread frontend/src/app/features/member/form/member-form.component.ts Outdated
Comment thread frontend/src/app/features/member/form/member-form.component.ts Outdated
Comment thread frontend/src/app/features/roles/role.service.spec.ts
Comment thread frontend/src/app/features/member/form/member-form.component.ts
Comment thread frontend/src/app/features/calculations/calculation.service.spec.ts Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/calculation/Calculation.java Outdated
@fstreit1
fstreit1 force-pushed the feature/581-map-member-directly-to-roles branch from 11afa04 to 1c2a659 Compare August 25, 2026 12:22
MasterEvarior
MasterEvarior requested changes Aug 26, 2026
View reviewed changes

@MasterEvarior MasterEvarior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress for your first fullstack ticket. There are still a lot of minor things to iron out but it works 💯

Comment thread backend/src/main/java/ch/puzzle/pcts/controller/MemberController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/MemberController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/member/MemberDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/MemberMapper.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberrole/MemberRole.java Outdated
Comment thread frontend/src/app/features/member/form/member-form.component.ts Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/MemberControllerIT.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/RoleMapper.java Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/service/business/MemberBusinessServiceTest.java Outdated
Comment thread backend/src/main/resources/db/migration/V0_0_25__create_table_member_role.sql Outdated
@fstreit1
feat(db): add a new script for migration #581
2a8d61e
@fstreit1
feat(frontend): write a service which handels role operations #581
57e174a
@fstreit1
feat(frontend): add role attribute to frontend member model #581
973c776
@fstreit1
feat(frontend): implement new input field and naming in de.json #581
346b978
@fstreit1
just a wip commit that needs to be removed
0f05a21
@fstreit1
feat(frontend): add list with roles to member as attribute #581
3e62c76
@fstreit1
feat(backend): add list with roles to member as attribute #581
e664aad
@fstreit1
feat(backend): refactorer mapper so the roles get mapped correctly #581
efd5a91
@fstreit1
feat(frontend): add new translation for role input field #581
9518d9d
@fstreit1
feat(frontend): add role transfering to service #581
78e1f06
@fstreit1
feat(frontend): add a new input field for roles #581
ee09879
@fstreit1
feat: change roles attribute to roleids on memberdtos and models #581
e274e3c
@fstreit1
refactor(frontend): remove unneeded matformfield on member detail view …
a208ce9 
…#581
@fstreit1
fix(frontend): change attribute in testdata to roleids #581
8207d49
@fstreit1
test(backend): add businessservice to membermapper test #581
bbc4953
@fstreit1
feat(frontend): try to make the input field work #581
7e44ad8
@fstreit1
feat(frontend): fix input field #581
1f24ff8
@fstreit1
fix(backend): fix builder method for members #581
3168da8
@fstreit1
feat(backend): implement new endpoint for getting all the calculation…
b6e85f3 
…s with a certain role
@fstreit1
test(frontend): fix test by defining whats expected #581
f44be94
@fstreit1
test(backend): fix testdata #581
fbbddbf
@fstreit1
test(backend): fix tests #581
77660d0
@fstreit1
refactor(backend): fix codesmells from sonarqube #581
04e1f47
@fstreit1
refactor(frontend): remove unused imports #581
9a313c8
@fstreit1
fix(frontend): fix the feature so roles without calculations get load…
7a50fda 
…ed to #581
@fstreit1
refactor(backend): remove unnecessary files #581
d2abf21
@fstreit1
fix: fix test data #581
37bed75
@fstreit1
fix(backend): fix typo in test name and refactor controller to match …
cf52595 
…convention #581
@fstreit1
refactor: change models #581
6e5437d
@fstreit1
refactor(db): remove unnecessary column in memberrole #581
26a3dcb
@fstreit1
fix(backend): fix typo #581
2b8a152
@fstreit1
fix(frontend): fix rolepoint list defining #581
d6dc0ba
@fstreit1
feat(frontend): fix list defining #581
ab88e24
@fstreit1
refactor(frontend): add early return #581
f3b9367
@fstreit1
feat(frontend): add translation to aria label #581
47fd90f
@fstreit1
refactor(frontend): rename choosen roles #581
44860e2
@fstreit1
feat(db): add dev data #581
3fdb7aa
@fstreit1
refactor(frontend): move method from service #581
36c9f35
@fstreit1
feat(frontend): write new validator for checking if list is subset fr…
174edb3 
…om another list #581
@fstreit1
test(frontend): refactor method in frontend and change test #581
e480a0d
@fstreit1
refactor(frontend): remove debugging logs #581
d50816a
@fstreit1
feat(backend): change endpoint so logic for getting all rolepoints pe…
3b1b7db 
…r member is solely in backend #581
@fstreit1
feat(frontend): change fetching to match new endpoint logic #581
645b18b
@fstreit1
refactor(frontend): remove unnecessary mock method #581
4611852
@fstreit1
fstreit1 force-pushed the feature/581-map-member-directly-to-roles branch from b8b4119 to 4611852 Compare September 1, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterEvarior MasterEvarior MasterEvarior requested changes
@schiltpuzzle schiltpuzzle schiltpuzzle requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Thirusiga Thirusiga

@fstreit1 fstreit1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Technical Story: Map Member directly to roles

4 participants

@fstreit1 @MasterEvarior @schiltpuzzle @Thirusiga