fix: exclude soft-deleted members from MemberRepository lookups #813

[carranza-javier]

Fixes #813

[MasterEvarior]

Thanks again for the PR :)

The changes do look a-okay, there are just some things about how the tests are organized that I would like addressed.

[MasterEvarior]

Just some very minor things now. While you're at it, please rebase your branch so that it is current with what is on our main. Else some checks will fail ❌

[carranza-javier]

Rebased, and simplified DELETED_MEMBER_4 as suggested

[MasterEvarior]

The changes do look good. You will have to rebase once again and I will try to figure out how to get the CI to display something else than "Waiting for status to be reported" 😅

[carranza-javier]

The branch is already rebased on your side

But regarding the changed files and review comments, i cann only mark them as "Viewed" on my end. Could you mark them as resolved? Maybe in this way the CI would continue, but im not sure :P

[MasterEvarior]

The branch is already rebased on your side

But regarding the changed files and review comments, i cann only mark them as "Viewed" on my end. Could you mark them as resolved? Maybe in this way the CI would continue, but im not sure :P

Yeah, it seems like I can rebase it from my side. So that is not something you need to worry about rn. I marked all the comments as resolved but I think I need to adjust something in our GH workflows. Because I am currently in school, it might take until I am at work again in the middle of this week.