Skip to content

Make "data" argument required in ModelChain.run_model_from_effective_irradiance #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2023
Merged

Make "data" argument required in ModelChain.run_model_from_effective_irradiance #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef30b17
Made "data" argument in the mc.run_model_from_effective_irradiance as…
k10blogger Apr 30, 2023
3643c0b
Maded "data" argument required for subfunction
k10blogger Apr 30, 2023
e356141
Removed "default None" from docstring
k10blogger May 1, 2023
0b03273
Added bug fix comment in v0.9.6 and contributors name.
k10blogger May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/sphinx/source/whatsnew/v0.9.6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ Enhancements

Bug fixes
~~~~~~~~~

* `data` can no longer be left unspecified in
:py:meth:`pvlib.modelchain.ModelChain.run_model_from_effective_irradiance`. (:issue:`1713`, :pull:`1720`)

Testing
~~~~~~~
Expand All @@ -37,3 +38,4 @@ Requirements
Contributors
~~~~~~~~~~~~
* Adam R. Jensen (:ghuser:`adamrjensen`)
* Siddharth Kaul (:ghuser:`k10blogger`)
10 changes: 5 additions & 5 deletions pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,7 @@ def _prepare_temperature_single_array(self, data, poa):
self.temperature_model()
return self

def _prepare_temperature(self, data=None):
def _prepare_temperature(self, data):
"""
Sets cell_temperature using inputs in data and the specified
temperature model.
Expand All @@ -1699,7 +1699,7 @@ def _prepare_temperature(self, data=None):

Parameters
----------
data : DataFrame, default None
data : DataFrame
May contain columns ``'cell_temperature'`` or
``'module_temperaure'``.

Expand Down Expand Up @@ -1878,13 +1878,13 @@ def run_model_from_poa(self, data):

return self

def _run_from_effective_irrad(self, data=None):
def _run_from_effective_irrad(self, data):
"""
Executes the temperature, DC, losses and AC models.

Parameters
----------
data : DataFrame, or tuple of DataFrame, default None
data : DataFrame, or tuple of DataFrame
If optional column ``'cell_temperature'`` is provided, these values
are used instead of `temperature_model`. If optional column
`module_temperature` is provided, `temperature_model` must be
Expand All @@ -1907,7 +1907,7 @@ def _run_from_effective_irrad(self, data=None):

return self

def run_model_from_effective_irradiance(self, data=None):
def run_model_from_effective_irradiance(self, data):
"""
Run the model starting with effective irradiance in the plane of array.

Expand Down