Skip to content

Add hint about Perez discontinuities #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 4 commits into from
Jun 21, 2024
Merged

Add hint about Perez discontinuities #2098

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09f0647
Add hint about Perez discontinuities
AdamRJensen Jun 20, 2024
5d1e70a
Update warning
AdamRJensen Jun 20, 2024
adab278
Apply suggestions from code review
AdamRJensen Jun 20, 2024
7d5ee1e
Apply suggestions from code review
AdamRJensen Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,11 @@ def get_sky_diffuse(surface_tilt, surface_azimuth,
require ``'dni_extra'``. Values can be calculated using
:py:func:`~pvlib.irradiance.get_extra_radiation`.

The ``'Perez'`` transposition model features discontinuities in the
predicted tilted diffuse irradiance due to relying on discrete input
values. For applications that benefit from continuous output, consider
using :py:func:`~pvlib.irradiance.perez_driesse`.

The ``'perez'`` and ``'perez-driesse'`` models require relative airmass
(``airmass``) as input. If ``airmass`` is not provided, it is calculated
using the defaults in :py:func:`~pvlib.atmosphere.get_relative_airmass`.
Expand Down Expand Up @@ -1004,6 +1009,13 @@ def perez(surface_tilt, surface_azimuth, dhi, dni, dni_extra,
pressure-corrected) airmass. Optionally a selector may be used to
use any of Perez's model coefficient sets.

Warning
-------
The Perez transposition model features discontinuities in the
predicted tilted diffuse irradiance due to relying on discrete input
values. For applications that benefit from continuous output, consider
using :py:func:`~pvlib.irradiance.perez_driesse`.

Parameters
----------
surface_tilt : numeric
Expand Down