[WIP] Implement the Plataforma Solar de Almerı́a (PSA) solar position algorithm#2152
[WIP] Implement the Plataforma Solar de Almerı́a (PSA) solar position algorithm#2152kandersolar wants to merge 1 commit intopvlib:mainfrom
Conversation
|
Are you implementing the 2001 version or the 2020 version? |
|
The equations are the same between the two versions; only the coefficients differ. The current function lets the user choose which set of coefficients to use, with 2020 coefficients being the default. |
|
In the equations in the 2020 paper, it seems that the right ascension |
|
Given that the PSA and Michalsky algorithms are almost the same, maybe we should consider only adding Michalsky? |
Could you elaborate on the similarities/differences? I think the main usage of these algorithms will be to verify or replicate published output from other people or software, so even small differences could be relevant. |
|
Closing, will pursue solar position algorithm improvements in fresh PRs. |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The PSA algorithm seems to be as accurate as pvlib's ephemeris method but 3-4 times faster. Here is a brief comparison: