Skip to content

Update get_extra_radiation references #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 23, 2025

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Apr 14, 2025

  • Closes get_extra_radiation references could use an update #2333
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini added this to the v0.12.1 milestone Apr 14, 2025
@RDaxini RDaxini changed the title [WIP] Update get_extra_radiation references Update get_extra_radiation references Apr 14, 2025
@RDaxini
Copy link
Contributor Author

RDaxini commented Apr 14, 2025

Ready for an initial review.
I suggested some text so that the Duffie/Beckman and Reno et al references could be linked. Other references were linked to their respective model. I removed the Partridge reference, will reinstate if someone can indicate for what it was a reference.

A notes section with some more explanation/theory might be worth considering in future.

@RDaxini RDaxini marked this pull request as ready for review April 14, 2025 21:43
Comment on lines 91 to 92
.. [6] I. Reda, A. Andreas, "Solar position algorithm for solar
radiation applications" NREL Golden, USA. NREL/TP-560- 34302, 2008.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOI: https://doi.org/10.2172/15003974

Title has changed to include "revised"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added revised before the year, since the official title in the quotation marks still appears to be the same title. Let me know whether you think this is correct

@kandersolar kandersolar merged commit 8a7927a into pvlib:main Apr 23, 2025
30 checks passed
@kandersolar
Copy link
Member

Thanks @RDaxini!

@RDaxini RDaxini deleted the get_extra_radiation_references branch April 23, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_extra_radiation references could use an update
4 participants