-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update get_extra_radiation
references
#2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get_extra_radiation
references
#2437
Conversation
get_extra_radiation
referencesget_extra_radiation
references
Ready for an initial review. A notes section with some more explanation/theory might be worth considering in future. |
pvlib/irradiance.py
Outdated
.. [6] I. Reda, A. Andreas, "Solar position algorithm for solar | ||
radiation applications" NREL Golden, USA. NREL/TP-560- 34302, 2008. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DOI: https://doi.org/10.2172/15003974
Title has changed to include "revised"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added revised before the year, since the official title in the quotation marks still appears to be the same title. Let me know whether you think this is correct
Thanks @RDaxini! |
get_extra_radiation
references could use an update #2333Tests addedUpdates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.