[codex] Fix compaction stop and detach cleanup#89
Open
eeelvn-bot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a generic compaction lifecycle bug in the Codex app server plugin.
It does not add Feishu-specific behavior. The change applies to any channel that exposes the status card controls, including Telegram, Discord, and Feishu/Lark.
What Changed
compactThread()to be aborted viaAbortSignalStopDetachRoot Cause
Compactstarted its own keepalive timer, but that timer was not registered inactiveRunsand had no dedicated cancellation path.As a result,
StopandDetachcould interrupt normal turn runs, but they could not clear an in-flight compaction keepalive loop. If compaction stalled or never settled, the plugin could continue emittingCodex is still compacting.messages indefinitely.Why This Is Separate
This is a host/plugin lifecycle fix, not a Feishu support change. It is split out so the Feishu/Lark support PR stays minimal and reviewable.
Validation
pnpm typecheckpnpm test