fix: keep plan runs active while questionnaire input is pending#95
fix: keep plan runs active while questionnaire input is pending#95kesslerio wants to merge 3 commits into
Conversation
|
Follow-up patch for the pending-input lifecycle fix. The first version kept the run alive long enough for questionnaire callbacks to get through, but it could still leave a restored run behind after the last answer. This update closes that hole. What changed:
Coverage added:
Verified with:
ELIFECYCLE Test failed. See above for more details.
|
|
Follow-up patch for the pending-input lifecycle fix. The first pass kept the run alive long enough for questionnaire callbacks to get through, but it could still leave a restored run behind after the last answer. This update closes that hole. What changed:
Coverage added:
Verified with:
|
|
Thanks for this PR! I have a similar issue, however, after the first question CAS automatically replies to me that I have not selected any question. Does it happen to you as well? Anyway is this project still alive? there are so many unanswered PR/issues lately. I love this plugin and I'm extensively using it every day. |
What
/cas_planquestionnaire pathWhy
/cas_plancould ask the first question and then drop the run that was supposed to receive the answer. The questionnaire stayed visible, but answering it failed withNo active Codex run is waiting for input.The controller was cleaning up the run as soon as the initial turn result settled, even when Codex was still blocked on
requestUserInput. This patch keeps the run alive until that pending input actually clears, then cleans it up normally.Tests
pnpm test src/controller.test.tspnpm typecheckpnpm testAI assistance
Codex drafted the patch and regression. I reviewed the cleanup logic, the repro, and the test results before opening the PR.
Fixes #93