Skip to content

ROB: ignore annotation with Go-To action missing a /D name attribute (#3211) #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ROB: ignore annotation with Go-To action missing a /D name attribute (#3211) #3213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pypdf/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2968,7 +2968,10 @@
anc[NameObject("/Dest")] = ArrayObject([p] + d[1:])
outlist.append(self._add_object(anc))
else:
d = cast("DictionaryObject", ano["/A"])["/D"]
annot_obj = cast("DictionaryObject", ano["/A"])
if "/D" not in annot_obj:
continue

Check warning on line 2973 in pypdf/_writer.py

View check run for this annotation

Codecov / codecov/patch

pypdf/_writer.py#L2973 

Added line #L2973 was not covered by tests
d = annot_obj["/D"]
if isinstance(d, NullObject):
continue
if isinstance(d, str):
Expand Down
Loading