Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
#
# Single open-circuit potential, same for charge and discharge
#
import pybamm
from . import BaseOpenCircuitPotential

Check warning on line 5 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L4-L5

Added lines #L4 - L5 were not covered by tests


class RKOpenCircuitPotential(BaseOpenCircuitPotential):

Check warning on line 8 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L8

Added line #L8 was not covered by tests
"""Class for the Open Circuit Potential for implementing RK-Polynomial method
taking stoichimetry and temperature as input"""

def get_coupled_variables(self, variables):
domain, Domain = self.domain_Domain
phase_name = self.phase_name

Check warning on line 14 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L12-L14

Added lines #L12 - L14 were not covered by tests

if self.reaction == "lithium-ion main":
T = variables[f"{Domain} electrode temperature [K]"]

Check warning on line 17 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L16-L17

Added lines #L16 - L17 were not covered by tests
# For "particle-size distribution" models, take distribution version
# of c_s_surf that depends on particle size.
domain_options = getattr(self.options, domain)
if domain_options["particle size"] == "distribution":
sto_surf = variables[

Check warning on line 22 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L20-L22

Added lines #L20 - L22 were not covered by tests
f"{Domain} {phase_name}particle surface stoichiometry distribution"
]
# If variable was broadcast, take only the orphan
if isinstance(sto_surf, pybamm.Broadcast) and isinstance(

Check warning on line 26 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L26

Added line #L26 was not covered by tests
T, pybamm.Broadcast
):
sto_surf = sto_surf.orphans[0]
T = T.orphans[0]
T = pybamm.PrimaryBroadcast(T, [f"{domain} {phase_name}particle size"])

Check warning on line 31 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L29-L31

Added lines #L29 - L31 were not covered by tests
else:
sto_surf = variables[

Check warning on line 33 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L33

Added line #L33 was not covered by tests
f"{Domain} {phase_name}particle surface stoichiometry"
]
# If variable was broadcast, take only the orphan
if isinstance(sto_surf, pybamm.Broadcast) and isinstance(

Check warning on line 37 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L37

Added line #L37 was not covered by tests
T, pybamm.Broadcast
):
sto_surf = sto_surf.orphans[0]
T = T.orphans[0]

Check warning on line 41 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L40-L41

Added lines #L40 - L41 were not covered by tests

inputs = {

Check warning on line 43 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L43

Added line #L43 was not covered by tests
f"{Domain} particle stoichiometry": sto_surf,
f"{Domain} electrode temperature [k]": T,
}

OCP_surf = pybamm.FunctionParameter(

Check warning on line 48 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L48

Added line #L48 was not covered by tests
f"{Domain} electrode RK_OCP [V]", inputs
)

dUdT = self.phase_param.dUdT(sto_surf)

Check warning on line 52 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L52

Added line #L52 was not covered by tests

# Bulk OCP is from the average SOC and temperature
sto_bulk = variables[f"{Domain} electrode {phase_name}stoichiometry"]
T_bulk = pybamm.xyzs_average(T)
ocp_bulk = self.phase_param.U(sto_bulk, T_bulk)

Check warning on line 57 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L55-L57

Added lines #L55 - L57 were not covered by tests

variables.update(self._get_standard_ocp_variables(OCP_surf, ocp_bulk, dUdT))
return variables

Check warning on line 60 in src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py

View check run for this annotation

Codecov / codecov/patch

src/pybamm/models/submodels/interface/open_circuit_potential/rk_ocp_temp_dependent.py#L59-L60

Added lines #L59 - L60 were not covered by tests
Loading