Skip to content

chore: update nox and test deps #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 1, 2025

Description

Update some test deps and modernize the noxfile. The make_changelog script now supports PEP 723 runners, so you can, for example, do uv run make_changelog.py or pipx run make_changelog.py.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/chore/nox2025 branch from 78e65d1 to 807c707 Compare April 1, 2025 16:31
@henryiii henryiii requested a review from Copilot April 1, 2025 18:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates testing dependencies and modernizes script runners, notably updating the shebangs for Python scripts and refining nox session usage.

  • Update shebangs and add script metadata comments in tools/make_changelog.py and noxfile.py
  • Upgrade nox version requirements and adjust nox session decorators
  • Add and remove PYBIND11_NUMPY_1_ONLY flags in CI job configurations

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tools/make_changelog.py Updated shebang to use "uv run" and added metadata comments
noxfile.py Updated shebang, version requirement, and modified session decorators
.github/workflows/ci.yml Adjusted PYBIND11_NUMPY_1_ONLY flag usage in different CI job sections
Files not reviewed (1)
  • tests/requirements.txt: Language not supported
Comments suppressed due to low confidence (3)

noxfile.py:57

  • Setting default=False for the docs session changes its default execution behavior. Verify that this is intentional, and update documentation if needed.
@nox.session(reuse_venv=True, default=False)

.github/workflows/ci.yml:69

  • The removal of the -DPYBIND11_NUMPY_1_ONLY=ON flag in the first build configuration may lead to inconsistent behavior compared to other job sections. Confirm whether this change is intentional and consistent with the desired build setup.
-DPYBIND11_NUMPY_1_ONLY=ON

.github/workflows/ci.yml:69

  • Similarly, the removal of the -DPYBIND11_NUMPY_1_ONLY=ON flag in the second build configuration could cause inconsistencies across builds. Please verify that this removal aligns with the intended build configuration strategy.
-DPYBIND11_NUMPY_1_ONLY=ON

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@henryiii henryiii merged commit 55b1357 into pybind:master Apr 2, 2025
75 checks passed
@henryiii henryiii deleted the henryiii/chore/nox2025 branch April 2, 2025 12:24
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants