-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for custom ext. policies support. #12459
Changelog entry for custom ext. policies support. #12459
Conversation
Hope this reads all right, writing is hard 😄 |
CHANGELOG.rst
Outdated
This includes deprecation of some :class:`~cryptography.x509.verification.ClientVerifier` | ||
and :class:`~cryptography.x509.verification.ServerVerifier` properties, | ||
which will be removed in the next release of ``cryptography``, and a | ||
breaking change to the :class:`~cryptography.x509.verification.VerifiedClient` API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to be more specific about the deprecations/breaking change. Which properties are deprecated, and what's the breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this looks good. I know Alex has already said this, but you have been a fantastic contributor here. I hope you stick around 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, it means a lot, especially since this was my first time contributing to an open source project 😄. Feel free to ping me in regard to extending this API further (I think the next logical step would probably be arbitrary extension type support.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up though, I almost definitely won't be able to work on anything large scale until the end of July, since the last semester of my master's program starts this Monday and I will have to finish writing my thesis and stuff 😄
No description provided.