Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PolicyBuilder.extension_policies keyword-only. #12476

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

deivse
Copy link
Contributor

@deivse deivse commented Feb 16, 2025

#12432 (comment)

I decided to remove the new_ prefix from the argument names, because that is a bit too annoying to write out for me. There is a slight inconsistency now with how the other arguments are named, but I can personally live with that.
If we do want to keep it consistent, I would rather remove new_ from all PolicyBuilder argument names than force users to write out new_ee_policy and new_ca_policy every time 😅 But that's just my personal preference of course 😄

@deivse
Copy link
Contributor Author

deivse commented Feb 16, 2025

Regarding the naming, I just searched through the code quickly, and I don't think any other builder APIs use the new_xxx naming scheme, so I guess removing the new_ prefix from all parameter names would actually improve overall consistency. I'm going to do that preliminarily, and I can revert if you don't agree.

@alex alex merged commit 4d7bcee into pyca:main Feb 16, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants