Add missing return type hint for resources.py - #1906
Closed
vetleledaal wants to merge 1 commit into
Closed
Conversation
vetleledaal
force-pushed
the
chore/add-missing-return-type-hint-resources.py
branch
from
June 27, 2025 10:19
2a77059 to
7dd1494
Compare
vetleledaal
force-pushed
the
chore/add-missing-return-type-hint-resources.py
branch
from
June 27, 2025 10:26
7dd1494 to
6abce9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
jira/resources.py::Issue::permalinkis an untyped function, it should be typed.Why?
The
jiramodule advertises itself as supporting type hints viapy.typed. When used in a typed context and with mypy's strict mode it will complain about the current implementation.How?
Adding return type hints to
jira/resources.pywould mitigate the issue.Testing?
Has not been tested in runtime. With PEP 563 it is impossible for this PR to break anything under normal conditions. Worst case is that tools used during development show incorrect information, such as an LSP or linter.
Anything Else?
While adding type hints everywhere would be ideal, the PR scope is limited for easier reviewability.
Changes can be summarized as; all methods return
None, except for:jira/resources.py::Attachment::get, which returnsbytes | Nonejira/resources.py::Issue::permalink, which returnsstrCloses #1900.