Add managed variables #1548
Open
Add managed variables #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
commented
Nov 25, 2025
1 task
|
@alexmojaki I've opened a new pull request, #1549, to work on those changes. Once the pull request is ready, I'll request review from you. |
Deploying logfire-docs with
|
| Latest commit: |
0d8acc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95e13453.logfire-docs.pages.dev |
| Branch Preview URL: | https://managed-variables.logfire-docs.pages.dev |
alexmojaki
commented
Nov 25, 2025
alexmojaki
commented
Nov 25, 2025
dmontagu
force-pushed
the
managed-variables
branch
from
735b295 to
ce01469
Compare
alexmojaki
commented
Dec 1, 2025
alexmojaki
commented
Dec 5, 2025
alexmojaki
commented
Dec 5, 2025
alexmojaki
commented
Dec 16, 2025
alexmojaki
commented
Dec 18, 2025
alexmojaki
commented
Dec 18, 2025
tests/test_push_variables.py
Outdated
Comment on lines
234
to
251
| assert 'orphan-feature' in diff.orphaned_server_variables | ||
| assert 'my-feature' not in diff.orphaned_server_variables |
Contributor
Author
There was a problem hiding this comment.
Please replace as many assertions as possible with inline-snapshot
alexmojaki
commented
Dec 19, 2025
dmontagu
force-pushed
the
managed-variables
branch
from
9c2962a to
1b755d0
Compare
dmontagu
force-pushed
the
managed-variables
branch
from
1da19bc to
bcaefd8
Compare
alexmojaki
force-pushed
the
managed-variables
branch
from
ecb204c to
280697e
Compare
Draft
dmontagu
force-pushed
the
managed-variables
branch
from
affe371 to
92c924f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.