Skip to content

fix: replace assert with proper exception in query client #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glitch-ux wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: replace assert with proper exception in query client #1856

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b5a8e
fix: replace assert with proper exception in query client's handle_re…
glitch-ux Apr 10, 2026
79e82ca
Update logfire/experimental/query_client.py
glitch-ux Apr 10, 2026
532c392
Merge branch 'main' into fix/replace-assert-with-proper-exception-in-…
glitch-ux Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion logfire/experimental/query_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ def handle_response_errors(self, response: Response) -> None:
raise QueryExecutionError(response.json())
if response.status_code == 422: # pragma: no cover
raise QueryRequestError(response.json())
assert response.status_code == 200, response.content
if response.status_code != 200:
raise QueryExecutionError(f'Unexpected response status code: {response.status_code}, body: {response.text}')


class LogfireQueryClient(_BaseLogfireQueryClient[Client]):
Expand Down
Loading