Add pathlib symlink and metadata OS calls#336
Open
chaliy wants to merge 6 commits intopydantic:mainfrom
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Author
|
PR touches the monty-dataset, which triggers a considerable number of code paths that are not covered by unit tests. Should I still attempt to satisfy codecov? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds the pathlib symlink and metadata filesystem operations requested in issue #335.
Path.readlink()Path.symlink_to(...)Path.chmod(...)Path.lstat()andPath.stat(follow_symlinks=False)AbstractOS/OSAccesssurface accordinglyWhy
Monty already exposed parts of pathlib filesystem access, but it could not round-trip symlink targets, create symlinks, change mode bits, or request non-following stat metadata. This closes that gap for the OS-call surface and the Python callback API.
Notes
AbstractOSremains backward-compatible via thepath_lstat()fallback topath_stat()OverlayMemorystill reportsPath.chmod()andPath.symlink_to()as unsupported; that mode needs an explicit in-memory symlink model for full parityValidation
make format-rsmake lint-rsmake lint-pycargo test -p monty --test os_tests --features ref-count-paniccargo test -p monty --test fs --features ref-count-panic