Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
🚩 Stale check_types references in unchanged docstrings
The docstring at lines 68-69 of crates/monty-type-checking/src/db.rs still references check_types ("Program settings needed by check_types") even though the PR replaces all usage with check_file_unwrap. Similarly, crates/monty-type-checking/src/pool.rs:125 says "e.g. for check_types or rendering". These are pre-existing context lines not in the diff hunks, but they became stale as a direct result of this PR's changes. Per the CLAUDE.md rule about updating stale comments, these should be updated in a follow-up.
Was this helpful? React with 👍 or 👎 to provide feedback.
| def display(self, format: Literal['traceback', 'type-msg', 'msg'] = 'traceback') -> str: | ||
| """Returns formatted exception string. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
🚩 MontySyntaxError.display() pyi docstring incomplete for new 'traceback' format
The type stub at crates/monty-python/python/pydantic_monty/_monty.pyi:846 correctly lists 'traceback' in the Literal type and as the default, but the docstring at lines 849-851 only documents 'type-msg' and 'msg' formats — it doesn't document 'traceback'. Compare with MontyRuntimeError.display() at line 891-897 which documents all three formats. This is a documentation gap in the public API stub.
(Refers to lines 846-852)
Was this helpful? React with 👍 or 👎 to provide feedback.
Codecov Results 📊❌ Patch coverage is 65.79%. Project has 23799 uncovered lines. Files with missing lines (4)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 64.56% 64.55% -0.01%
==========================================
Files 258 258 —
Lines 67096 67126 +30
Branches 143260 143312 +52
==========================================
+ Hits 43314 43327 +13
- Misses 23782 23799 +17
- Partials 3241 3272 +31Generated by Codecov Action |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| """Returns formatted exception string. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
🟡 MontySyntaxError.display() docstring missing documentation for 'traceback' format (now the default)
The .pyi docstring for MontySyntaxError.display() at crates/monty-python/python/pydantic_monty/_monty.pyi:846-852 does not document the 'traceback' format option, despite it being the new default. The docstring only lists 'type-msg' and 'msg'. Compare with MontyRuntimeError.display() at crates/monty-python/python/pydantic_monty/_monty.pyi:891-898, which correctly documents all three formats including 'traceback' - full traceback with exception. This violates CLAUDE.md: "If you encounter a comment or docstring that's out of date - you MUST update it to be correct."
(Refers to lines 847-852)
Was this helpful? React with 👍 or 👎 to provide feedback.
Use ruff parsing depth limits as per astral-sh/ruff#24810