Draft
Conversation
Implements an `Approval` capability that intercepts tool execution via `wrap_tool_execute` and calls a user-supplied callback to approve or deny tool calls. Supports glob-based tool name matching and three approval modes: `always` (ask every time), `once` (ask first time, remember for the run), and `never` (auto-approve, for testing). Refs #29 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…ol stubs - Add direct test for mode='once' auto-approval on repeated tool calls (covers line 136: the cached approval branch) - Mark tool function bodies that are intentionally never executed (denied) with `# pragma: no cover` Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
DouweM
requested review from
Kludex,
adtyavrdhn,
dmontagu,
dsfaccini and
samuelcolvin
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
Audit vs prior art: ApprovalWorth adding now:
Follow-up opportunities:
|
Contributor
Author
Audit vs prior art: ApprovalWorth adding now:
Follow-up opportunities:
|
DouweM
removed request for
Kludex,
adtyavrdhn,
dmontagu,
dsfaccini and
samuelcolvin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approval, a capability for human-in-the-loop tool approval workflows usingwrap_tool_executedelete_*,send_email,*), configurable approval modes (always/once/never), and sync or async approval callbacksfrom pydantic_harness import ApprovalCloses #29
Test plan
for_runisolation, serialization opt-out, and internal helpersDesign notes
Uses
wrap_tool_executeto intercept tool execution inline. WhenDeferredToolCallsPresent(#142) lands in core, this capability can be updated to useon_node_run_error+ deferred tools for a more structured flow, but the public API would remain the same.Generated with Claude Code