[WiP] Approvals for tools from within Code Mode#211
Open
adtyavrdhn wants to merge 8 commits intomainfrom
Open
Conversation
…id from monty to be used
Member
Author
|
CC @DouweM I am not a fan of having to do this round after round for tools, this is a UX concern for sure. We should discuss how we want to do HITL. I have some ideas :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A couple of people have pointed out the lack of this is concerning so I am inclined to just ship this which doesn't need core changes at all anymore thanks to @DouweM :)
Follows the same pattern we agreed on before:
tool_call_idofrun_codeApprovalRequiredNot the prettiest but I like it for the less surface area we are dealing with, one thing I don't like currently is the back and forth between approvals. I would prefer to collect all the approvals required and send them in one go as a request but one thing to keep in mind would be that they would still need to be keyed to the same
tool_call_idthatrun_codehas because that is the upper tool which will have thectx.tool_call_approvedLinked Issue
Fixes #
Checklist
make lint && make typecheck && make testpasses locally (don't stress about CI -- we'll help)pyproject.tomloruv.lock(dependency changes require a separate issue)