-
Notifications
You must be signed in to change notification settings - Fork 12
feat(code_mode): resolve deferred/approval-required tool calls via HandleDeferredToolCalls
#220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fa04d75
93a49a7
1bfbaaf
2de20c4
f019887
7285593
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Stale docstring claims deferred-execution tools are excluded from sandbox The Was this helpful? React with 👍 or 👎 to provide feedback. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Class docstring now describes behavior the PR removed
The
CodeModeToolsetclass docstring atpydantic_ai_harness/code_mode/_toolset.py:170-171still says "Tools that require deferred execution (kindexternal/unapproved) cannot be called from inside the sandbox and are dropped with a one-timeUserWarning." This is now factually incorrect — the entire point of this PR is to sandbox those tools instead. The docstring was not updated because it falls in unchanged context lines, but it will be misleading to anyone reading the class documentation.Was this helpful? React with 👍 or 👎 to provide feedback.