Bump Pyright and Ruff #3049
Open
Bump Pyright and Ruff #3049
+172
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
# Conflicts: # pydantic_ai_slim/pydantic_ai/_run_context.py
Merge main into bump-pyright branch to get latest changes. Conflicts resolved: - pydantic_ai_slim/pydantic_ai/_output.py - pydantic_ai_slim/pydantic_ai/_utils.py - pydantic_ai_slim/pydantic_ai/ag_ui.py (took main's refactored version) - pydantic_ai_slim/pydantic_ai/durable_exec/temporal/__init__.py - pydantic_ai_slim/pydantic_ai/models/__init__.py - pydantic_ai_slim/pydantic_ai/models/fallback.py - tests/models/mock_openai.py - uv.lock Updated versions: - pyright: 1.1.405 -> 1.1.407 - ruff: 0.13.2 -> 0.14.8 Note: 589 pyright errors remain to be fixed (this is expected - the purpose of this branch is to bump pyright and fix the resulting type errors).
Fixes pyright errors by using typed factories like `list[str]` instead of untyped `list` in dataclass field default_factory arguments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add inline ignores for complex type covariance issues with Task tuples. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
Author
|
@dsfaccini I worry about all the merge conflicts and linter failures this will cause in currently open PRs that are fine now, but will break once they merge in main, or worse: when we merge the PRs into main and main will break. So let's merge this just before the Christmas break when there will be less activity anyway, and then everyone can fix their PRs once they're back to work in January. Will you remind me? |
Collaborator
|
yessir |
Collaborator
|
after we merge #3778 I don't think the burden of resolving conflicts will make sense here, simply syncing and re-locking caught a bunch of the type issues, so I'd much rather bump pyright and ruff in a new branch after we merge 3778. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.