Better follow otel semconv #3741
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Dec 16, 2025
| class ReasoningPart(TypedDict): | ||
| """A reasoning/thinking part in a GenAI message. | ||
| Per the semantic conventions, uses 'reasoning' type. |
Contributor
Author
There was a problem hiding this comment.
You can find UriPart, BlobPart, and ReasoningPart in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-input-messages.json with this schema. Not sure how practical it is for us to change this in the immediate future but I think we'll want to comply with those conventions asap..
dmontagu
commented
Dec 16, 2025
| type: Literal['tool_call_response'] | ||
| id: str | ||
| name: str | ||
| # TODO: This should be `response` not `result` |
Contributor
Author
There was a problem hiding this comment.
This is also noted in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-input-messages.json, I can update the PR to make this change you want, or I can revert the changes to the other types below.
Docs Preview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexmojaki not sure if you wanted to use
responseinstead ofresulttoday; also not sure if we should wait to introduce these changes for "version 4" of the observability or similar. Or if we should keep this open and just make the changes when we release the next major version of pydantic-ai..?