-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Install lowest direct in CI #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Docs Preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 9
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0; (sys_platform != 'darwin' or platform_machine != 'x86_64')", "transformers>=4.0.0", "pillow", "torch; (sys_platform != 'darwin' or platform_machine != 'x86_64')"] | ||
| outlines-llamacpp = ["outlines[llamacpp]>=1.0.0, <1.3.0"] | ||
| outlines-mlxlm = ["outlines[mlxlm]>=1.0.0, <1.3.0; platform_system == 'Darwin' and platform_machine == 'arm64'"] | ||
| outlines-sglang = ["outlines[sglang]>=1.0.0, <1.3.0", "pillow"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent version specifier excludes Pillow 11.0.0
The pillow>11.0.0 constraint uses an exclusive lower bound (>) while all other version constraints in the file consistently use inclusive bounds (>=). In the same PR, vllm>=0.8.0 uses >=. Since Pillow has no version between 11.0.0 and 11.1.0, this effectively sets the minimum to 11.1.0, potentially excluding a valid version. If the intent was to require Pillow 11.0.0 or later, this appears to be a typo and >=11.0.0 would be the correct specifier.
|
|
||
| AsyncAnthropicClient: TypeAlias = AsyncAnthropic | AsyncAnthropicBedrock | AsyncAnthropicVertex | ||
| if TYPE_CHECKING: | ||
| AsyncAnthropicClient: TypeAlias = AsyncAnthropic | AsyncAnthropicBedrock | AsyncAnthropicVertex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Type alias moved to TYPE_CHECKING breaks runtime import
The AsyncAnthropicClient type alias is now only defined under if TYPE_CHECKING:, but pydantic_ai/models/anthropic.py performs a runtime import with from ..providers.anthropic import AsyncAnthropicClient at line 49. Since TYPE_CHECKING is False at runtime, this import will fail with an ImportError, completely breaking the Anthropic model functionality.
|
|
||
| - run: uv sync --only-dev | ||
|
|
||
| - run: uv run mcp-run-python example --deps=numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DouweM is this still needed now that we have the mcp-run-python in another repo? I've already checked that this test is also ran on that repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex I'm fine removing it.
Note that we also test that it mcp-run-python be started here:
pydantic-ai/docs/mcp/client.md
Lines 140 to 152 in c1213e4
| from pydantic_ai import Agent | |
| from pydantic_ai.mcp import MCPServerStdio | |
| server = MCPServerStdio( # (1)! | |
| 'uv', args=['run', 'mcp-run-python', 'stdio'], timeout=10 | |
| ) | |
| agent = Agent('openai:gpt-5', toolsets=[server]) | |
| async def main(): | |
| result = await agent.run('How many days between 2000-01-01 and 2025-03-18?') | |
| print(result.output) | |
| #> There are 9,208 days between January 1, 2000, and March 18, 2025. |
That makes the test suite require deno. I actually think we should drop that entirely and really treat it as a separate package.
.github/workflows/ci.yml
Outdated
|
|
||
| - run: mkdir .coverage | ||
|
|
||
| - run: uv sync --only-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also move the ${{ matrix.install.command }} here and make the test command uv run --no-sync ...?
|
Some warnings from the lowest-versions job: |
|
|
||
| - run: uv run mcp-run-python example --deps=numpy | ||
| # We install the `--group dev` first because if we use `--package` together, it will try to install the `dev` group from the package. | ||
| - run: uv sync --group dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding matrix.install.command here didn't work?
Closes #3710
Note
Adjust CI to use lowest-direct installs and expand Python matrix, bump a few dependency pins, and harden tests with guarded imports and minor fixes.
uv sync --group devfirst and--resolution lowest-directfor lowest-versions; run pytest with--no-sync.3.11; increasetest-lowest-versionstimeout to35m; setUV_FROZEN="0"for lowest runs.exceptiongroup>=1.2.2(py<3.11).pillow>11.0.0,torch>=2.8.0,vllm>=0.8.0, andboto3-stubs[bedrock-runtime]>=1.40.64.try_import()and move some imports under TYPE_CHECKING.getattr.create_web_appHTML response.Written by Cursor Bugbot for commit 48b6562. This will update automatically on new commits. Configure here.