-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add bedrock_service_tier setting to BedrockModelSettings
#3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bedrock_service_tier setting to BedrockModelSettings
#3773
Conversation
also updated the version for boto3-stubs[bedrock-runtime] so that it included ServiceTierTypeDef
bedrock_service_tier setting to BedrockModelSettings
|
@lukekh |
involved upgrading boto3 so that serviceTier was recognized at the validation step
Head branch was pushed to by a user without write access
|
@lukekh Yes please update it for the optional dependency group; we shouldn't need to list it explicitly under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| interactions: | ||
| - request: | ||
| body: '{"messages": [{"role": "user", "content": [{"text": "What is the capital of France?"}]}], "system": [{"text": "You | ||
| are a helpful chatbot."}], "serviceTier": {"type": "default"}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cassette request mismatches test code service tier value
The test specifies bedrock_service_tier={'type': 'flex'} but the cassette file shows "serviceTier": {"type": "default"} in the recorded request body. This mismatch means the test isn't validating what it claims to test. The cassette appears to have been recorded with a different value than what the test code now uses, making the test unreliable for catching regressions in the bedrock_service_tier functionality.
also updated the version for
boto3-stubs[bedrock-runtime]so that it includedServiceTierTypeDefCloses #3761
Note
Adds Bedrock service tier support
BedrockModelSettings.bedrock_service_tier(typed asServiceTierTypeDef) and propagation to request paramserviceTierinbedrock.pyServiceTierTypeDef; request builder now includesserviceTierwhen providedtest_bedrock_model_service_tierwith VCR cassetteboto3>=1.42.14forbedrockextra andboto3-stubs[bedrock-runtime]>=1.42.13in dev/lockfilesWritten by Cursor Bugbot for commit e7ee858. This will update automatically on new commits. Configure here.