-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove deno dependency in CI #3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Docs Preview
|
tests/test_examples.py
Outdated
|
|
||
| class MockMCPServer(AbstractToolset[Any]): | ||
| # Common tools that tests need | ||
| _TOOLS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of all of this work to keep MCPServerStdio('python', args=['mcp_server.py']) working, can we change the mcp-run-python example to use mcp_server.py as well?
Remember that the goal of this PR is to get rid of those extra downloads mcp-run-python is doing + the Deno requirement, not to fully mock MCP (it's fine to call the local tests/mcp_server.py server which doesn't download anything)
| "mcpServers": { | ||
| "python-runner": { | ||
| "command": "uv", | ||
| "args": ["run", "mcp-run-python", "stdio"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we don't need to change it do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readded that mcp server, left in the one I added bc it's the one used in the snippets
| if TYPE_CHECKING: | ||
| from pydantic_ai.models.anthropic import AnthropicModel | ||
|
|
||
| ANTHROPIC_MODEL_FIXTURE = Callable[..., AnthropicModel] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're gonna wonder why I had to do these changes, I also have no idea, but perhaps the mcp-server example was installing a bunch of stuff that is now not being install in CI for pydantic-ai-slim
No description provided.