Skip to content

Conversation

davidhewitt
Copy link
Contributor

Change Summary

  • Unnecessary .clone() in EitherString::as_cow could clone strings needlessly
  • Split the lifetimes in EitherString, already done in EitherBytes and describes the possible data flow better

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Performance Report

Merging #1794 will not alter performance

Comparing dh/either-string-lifetimes (9c8e257) with main (d0dbb09)

Summary

✅ 163 untouched

@davidhewitt davidhewitt merged commit ecbc893 into main Sep 24, 2025
32 checks passed
@davidhewitt davidhewitt deleted the dh/either-string-lifetimes branch September 24, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant