This repository was archived by the owner on Apr 11, 2026. It is now read-only.
fix issue with field_serializers on nested typed dicts - #1879
Merged
Conversation
CodSpeed Performance ReportMerging #1879 will not alter performanceComparing Summary
|
Viicos
reviewed
Nov 3, 2025
Viicos
approved these changes
Nov 3, 2025
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Nov 5, 2025
…ntic-core#1879) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com> Original-commit-link: pydantic/pydantic-core@bed9c14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This cleans up a bunch of FIXME comments I left regarding
state.modelhandling in #1860.It turns out for the most part that a lot of the stuff going on in
fields.rswas redundant because model and dataclass serializers were already settingstate.model. However forTypedDict, the code infields.rswas supposed to be setting the model... but it was doing so extremely inconsistenty, and with problems for nested typed dicts.The added test fails on
main, passes the wrong typed dict to the nested field serializer.I simplified the control flow by just adding a thin
TypedDictSerializerwrapper which sets the state up in the same way as is done for models and dataclasses.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)