This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Clarify MultiHostUrl behavior for Postgres DSN without host - #1903
Closed
gcomneno wants to merge 9 commits into
Closed
Clarify MultiHostUrl behavior for Postgres DSN without host#1903gcomneno wants to merge 9 commits into
gcomneno wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates tests to document the current
MultiHostUrlbehavior for the Postgres DSN pattern:Today this is rejected with
url_parsing: empty host.What’s covered by the added cases
Accepted:
postgresql:///databasenamepostgresql:///databasename?user=derppostgresql://derp@%2Fvar%2Frun%2Fpostgresql/databasenameRejected:
postgresql://derp@/databasename?host=/var/run/postgresql→empty hostQuestion (maintainer guidance)
Would you prefer
MultiHostUrlto remain URL-strict here (i.e. keep rejectinguserinfo+ empty host), and keep any Postgres-DSN specific flexibility in a dedicated type/variant instead?CI note
Some checks are currently failing, but this appears unrelated to this test-only change (integration error:
SchemaValidator.__new__() got an unexpected keyword argument '_use_prebuilt', suggesting an environment/build mismatch). Happy to rerun/rebase once CI is green.Refs #378.
No runtime behavior changes.